-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): Support location filters for suites #7048
feat(cli): Support location filters for suites #7048
Conversation
- The jest of it is that we have a stricter matching mode, when a test location is passed: ```ts if (testLocations !== undefined && testLocations.length !== 0) { ``` We have three cases to deal with: 1. Parent did match via location filter, and as such this test is marked to run. No Questions asked. 2. This test / suite does match via location filter, and as such mark it to run, and do the same for its children. 3. No match. In this case I'd mark as skipped only it is a test. (if it's a suite, I still want to go through its children)
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks! |
Description
Closes #5445.
This is a continuation on my previous PR #6411, with support for matching location of suite.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.