fix(browser): stop the browser rpc when the pool is closed #6858

sheremet-va · 2024-11-05T12:56:14Z

Description

Related #6738

This is not a fix, but it does make the behaviour more consistent.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
Ideally, include a test that fails without this PR but passes with it.
Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

Run the tests with pnpm test:ci.

Documentation

If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

netlify · 2024-11-05T12:58:54Z

✅ Deploy Preview for vitest-dev ready!

Name	Link
🔨 Latest commit	`55a42a9`
🔍 Latest deploy log	https://app.netlify.com/sites/vitest-dev/deploys/672a15f2ca8de300080b4026
😎 Deploy Preview	https://deploy-preview-6858--vitest-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sheremet-va · 2024-11-05T13:15:09Z

@AriPerkkio I added a $close method to the birpc interface some time ago. It will reject any pending calls, so we don't keep hanging promises around. It's mostly useful if the timeout is too big, but also nice when we need to stop everything I guess 🤔

AriPerkkio · 2024-11-12T18:06:04Z

packages/browser/src/node/pool.ts

@@ -156,6 +161,11 @@ export function createBrowserPool(ctx: Vitest): ProcessPool {
    async close() {
      await Promise.all([...providers].map(provider => provider.close()))
      providers.clear()
+      ctx.resolvedProjects.forEach((project) => {
+        project.browser?.state.orchestrators.forEach((orchestrator) => {
+          orchestrator.$close()


Nice, so the $close is synchronous method that immediatelly closes everything?

Well, it rejects every promise that was started, but it doesn't close the channel itself since it's the responsibility of the one who setup the channel

rpc will also throw an error if another method is called again

sheremet-va · 2024-11-13T10:54:49Z

I have a feeling this will lead to some issues that were unnoticed before 😄 Let's see...

@sheremet-va

##### [v2.1.5](https://github.com/vitest-dev/vitest/releases/tag/v2.1.5) ##### 🚀 Features - **experimental**: Expose vite on the test project as a separate field - by [@sheremet-va](https://github.com/sheremet-va) [<samp>(bcc59)</samp>](vitest-dev/vitest@bcc59088) ##### 🐞 Bug Fixes - `dangerouslyIgnoreUnhandledErrors` without base reporter - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#6808 [<samp>(0bf0a)</samp>](vitest-dev/vitest@0bf0ab00) - Capture `unhandledRejection` even when base reporter is not used - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#6812 [<samp>(8878b)</samp>](vitest-dev/vitest@8878b04d) - Don't change the working directory when loading workspace projects - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6811 [<samp>(f0aea)</samp>](vitest-dev/vitest@f0aeaca8) - Remove `sequence.concurrent` from the `RuntimeConfig` type - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6880 [<samp>(6af73)</samp>](vitest-dev/vitest@6af73d93) - Stop the runner before restarting, restart on workspace config change - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6859 [<samp>(b01df)</samp>](vitest-dev/vitest@b01df47d) - Don't rerun on Esc or Ctrl-C during watch filter - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6895 [<samp>(98f76)</samp>](vitest-dev/vitest@98f76ea7) - Print ssrTransform error - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6885 [<samp>(4c96c)</samp>](vitest-dev/vitest@4c96cce7) - Throw an error and a warning if `.poll`, `.element`, `.rejects`/`.resolves`, and `locator.*` weren't awaited - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6877 [<samp>(93b67)</samp>](vitest-dev/vitest@93b67c24) - **browser**: - Don't process the default css styles - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6861 [<samp>(0d67f)</samp>](vitest-dev/vitest@0d67f04b) - Support non US key input - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6873 [<samp>(5969d)</samp>](vitest-dev/vitest@5969d8da) - Stop the browser rpc when the pool is closed - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6858 [<samp>(9a0c9)</samp>](vitest-dev/vitest@9a0c93d7) - Init browsers eagerly when tests are running - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6876 [<samp>(417bd)</samp>](vitest-dev/vitest@417bdb42) - **coverage**: - Report uncovered files when re-run by `enter` or `'a'` - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#6848 [<samp>(487c8)</samp>](vitest-dev/vitest@487c80ae) - **ui**: - Remove crossorigin attributes for same origin assets - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6883 [<samp>(6e793)</samp>](vitest-dev/vitest@6e793c64) - **vite-node**: - Improve esm check to decide external - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6816 [<samp>(7e1fa)</samp>](vitest-dev/vitest@7e1faf3d) - Top-level throw in module is not reported properly - by [@vanaigr](https://github.com/vanaigr) and [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6840 [<samp>(cf0cb)</samp>](vitest-dev/vitest@cf0cbf6a) - **vitest**: - Use fetch() implementation from happy-dom - by [@capricorn86](https://github.com/capricorn86) in vitest-dev/vitest#6879 [<samp>(3c56f)</samp>](vitest-dev/vitest@3c56feb4) ##### 🏎 Performance - Limit workspace project concurrency to available cores - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6869 [<samp>(f4c04)</samp>](vitest-dev/vitest@f4c04ab6) ##### [View changes on GitHub](vitest-dev/vitest@v2.1.4...v2.1.5)

@sheremet-va

##### [v2.1.5](https://github.com/vitest-dev/vitest/releases/tag/v2.1.5) ##### 🚀 Features - **experimental**: Expose vite on the test project as a separate field - by [@sheremet-va](https://github.com/sheremet-va) [<samp>(bcc59)</samp>](vitest-dev/vitest@bcc59088) ##### 🐞 Bug Fixes - `dangerouslyIgnoreUnhandledErrors` without base reporter - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#6808 [<samp>(0bf0a)</samp>](vitest-dev/vitest@0bf0ab00) - Capture `unhandledRejection` even when base reporter is not used - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#6812 [<samp>(8878b)</samp>](vitest-dev/vitest@8878b04d) - Don't change the working directory when loading workspace projects - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6811 [<samp>(f0aea)</samp>](vitest-dev/vitest@f0aeaca8) - Remove `sequence.concurrent` from the `RuntimeConfig` type - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6880 [<samp>(6af73)</samp>](vitest-dev/vitest@6af73d93) - Stop the runner before restarting, restart on workspace config change - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6859 [<samp>(b01df)</samp>](vitest-dev/vitest@b01df47d) - Don't rerun on Esc or Ctrl-C during watch filter - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6895 [<samp>(98f76)</samp>](vitest-dev/vitest@98f76ea7) - Print ssrTransform error - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6885 [<samp>(4c96c)</samp>](vitest-dev/vitest@4c96cce7) - Throw an error and a warning if `.poll`, `.element`, `.rejects`/`.resolves`, and `locator.*` weren't awaited - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6877 [<samp>(93b67)</samp>](vitest-dev/vitest@93b67c24) - **browser**: - Don't process the default css styles - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6861 [<samp>(0d67f)</samp>](vitest-dev/vitest@0d67f04b) - Support non US key input - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6873 [<samp>(5969d)</samp>](vitest-dev/vitest@5969d8da) - Stop the browser rpc when the pool is closed - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6858 [<samp>(9a0c9)</samp>](vitest-dev/vitest@9a0c93d7) - Init browsers eagerly when tests are running - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6876 [<samp>(417bd)</samp>](vitest-dev/vitest@417bdb42) - **coverage**: - Report uncovered files when re-run by `enter` or `'a'` - by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#6848 [<samp>(487c8)</samp>](vitest-dev/vitest@487c80ae) - **ui**: - Remove crossorigin attributes for same origin assets - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6883 [<samp>(6e793)</samp>](vitest-dev/vitest@6e793c64) - **vite-node**: - Improve esm check to decide external - by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6816 [<samp>(7e1fa)</samp>](vitest-dev/vitest@7e1faf3d) - Top-level throw in module is not reported properly - by [@vanaigr](https://github.com/vanaigr) and [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6840 [<samp>(cf0cb)</samp>](vitest-dev/vitest@cf0cbf6a) - **vitest**: - Use fetch() implementation from happy-dom - by [@capricorn86](https://github.com/capricorn86) in vitest-dev/vitest#6879 [<samp>(3c56f)</samp>](vitest-dev/vitest@3c56feb4) ##### 🏎 Performance - Limit workspace project concurrency to available cores - by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6869 [<samp>(f4c04)</samp>](vitest-dev/vitest@f4c04ab6) ##### [View changes on GitHub](vitest-dev/vitest@v2.1.4...v2.1.5)

fix(browser): stop the browser rpc when the pool is closed

55a42a9

sheremet-va requested a review from AriPerkkio November 7, 2024 15:55

AriPerkkio reviewed Nov 12, 2024

View reviewed changes

AriPerkkio approved these changes Nov 12, 2024

View reviewed changes

sheremet-va merged commit 9a0c93d into vitest-dev:main Nov 13, 2024
17 checks passed

sheremet-va deleted the fix/rpc-browser-stop branch November 13, 2024 10:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(browser): stop the browser rpc when the pool is closed #6858

fix(browser): stop the browser rpc when the pool is closed #6858

sheremet-va commented Nov 5, 2024 •

edited

Loading

netlify bot commented Nov 5, 2024

sheremet-va commented Nov 5, 2024

AriPerkkio Nov 12, 2024

sheremet-va Nov 12, 2024 •

edited

Loading

sheremet-va commented Nov 13, 2024

fix(browser): stop the browser rpc when the pool is closed #6858

fix(browser): stop the browser rpc when the pool is closed #6858

Conversation

sheremet-va commented Nov 5, 2024 • edited Loading

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Documentation

Changesets

netlify bot commented Nov 5, 2024

✅ Deploy Preview for vitest-dev ready!

sheremet-va commented Nov 5, 2024

AriPerkkio Nov 12, 2024

Choose a reason for hiding this comment

sheremet-va Nov 12, 2024 • edited Loading

Choose a reason for hiding this comment

sheremet-va commented Nov 13, 2024

sheremet-va commented Nov 5, 2024 •

edited

Loading

sheremet-va Nov 12, 2024 •

edited

Loading