Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vitest): Add missing defaults for server.deps.external #6807

Closed
wants to merge 2 commits into from

Conversation

RobinTail
Copy link
Contributor

@RobinTail RobinTail commented Oct 29, 2024

Description

Fixes #6806
According to the defaults described in the documentation: https://vitest.dev/config/#server-deps-external

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f3a80a9
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6720734235708800082f1108
😎 Deploy Preview https://deploy-preview-6807--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RobinTail RobinTail marked this pull request as ready for review October 29, 2024 05:58
@sheremet-va
Copy link
Member

sheremet-va commented Oct 29, 2024

defaults in the documentation are simplified. we actually have a lof of checks, but node_modules is a general idea. If we always externalise them, many user tests will fail when they use incorrectly packaged libraries

@RobinTail
Copy link
Contributor Author

RobinTail commented Oct 29, 2024

OK, then should be another PR on adjusting those checks to match import ... from "typescript", @sheremet-va

@sheremet-va
Copy link
Member

OK, then should be another PR on adjusting those checks to match import ... from "typescript", @sheremet-va

Yes, we need to find out why typescript is inlined at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.1.4: Failed to load source map for typescript.js
2 participants