Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vitest,runner): simplify test.extend type exports #6707

Merged
merged 8 commits into from
Oct 15, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add type module, then NodeNext is happy
hi-ogawa committed Oct 15, 2024
commit 2efa152ce12adeba2cc5c6b0ba620ba48d3909e9
1 change: 1 addition & 0 deletions test/dts-fixture/package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"name": "@vitest/test-dts-fixture",
"type": "module",
"private": true,
"scripts": {
"build": "rm -rf dist && tsc -p tsconfig.json",
8 changes: 2 additions & 6 deletions test/dts-fixture/tsconfig.check.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
{
"compilerOptions": {
"target": "ESNext",
// TODO: type check fails with NodeNext. probably we should fix this.
// ../../packages/vitest/index.d.cts:1:15 - error TS1479: The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("./dist/index.js")' call instead.
// 1 export * from './dist/index.js'
// ~~~~~~~~~~~~~~~~~
"module": "ESNext",
"moduleResolution": "Bundler",
"module": "NodeNext",
"moduleResolution": "NodeNext",
"types": [],
"strict": true,
"noEmit": true,