Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runner)!: support describe(..., { shuffle: boolean }) and inherit from parent suite #6670

Merged
merged 8 commits into from
Dec 5, 2024

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Oct 9, 2024

Description

This PR adds TestOptions.shuffle to allow "unshuffling" by describe("...", { shuffle: false }).

I noticed that describe.shuffle is not inherited to inner suites now, but probably changing this behavior would make sense to align with how concurrent works, so this change will be breaking.

One thing to note, when using config.sequence.shuffle: true, it's already shuffling all tests (as complained in #3922), so this use case is unchanged. What's breaking is when using describe.shuffle and using normal describe inside like in test/core/test/random.test.ts.

todo

  • should we hide types for test("..", { shuffle: boolean })?
  • test
  • docs

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e9acfc5
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6707583857cccd0008ca8fc4
😎 Deploy Preview https://deploy-preview-6670--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa hi-ogawa changed the title feat(runner)!: support TestOptions.shuffle and inherit from parent suite feat(runner)!: support describe(..., { shuffle: boolean }) and inherit from parent suite Oct 9, 2024
@hi-ogawa hi-ogawa marked this pull request as ready for review October 10, 2024 04:29
@sheremet-va sheremet-va modified the milestones: 3.0.0, 4.0.0 Dec 1, 2024
@sheremet-va sheremet-va merged commit aa1dac3 into vitest-dev:main Dec 5, 2024
16 of 17 checks passed
@hi-ogawa hi-ogawa deleted the feat-shuffle-option branch December 6, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run tests NOT in random order - unshuffle
2 participants