Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: always require curly braces #5885

Merged
merged 11 commits into from
Jun 16, 2024

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Jun 14, 2024

Description

Made curly braces required as discussed with the team. Eslint doesn't support autofix for this, so I run prettier and eslint on top of it 👀

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@sheremet-va sheremet-va requested a review from AriPerkkio June 14, 2024 10:25
@AriPerkkio
Copy link
Member

Build is now passing but there's an actual test failure. Maybe some change added some unicode characters?

 × test/public-api.test.ts > passes down metadata when 'running in the browser' 488ms
     → Unexpected token '�', "���z��" is not valid JSON

@AriPerkkio AriPerkkio force-pushed the lint/require-curly branch from 06e9728 to 4ed2c5b Compare June 16, 2024 10:20
@sheremet-va
Copy link
Member Author

sheremet-va commented Jun 16, 2024

@AriPerkkio can you update coverage tests? Since some lines have changed, snapshots and tests themselves (after snapshot update) are now failing

@sheremet-va sheremet-va merged commit 471cf97 into vitest-dev:main Jun 16, 2024
15 of 16 checks passed
@sheremet-va sheremet-va deleted the lint/require-curly branch June 16, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants