-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: always require curly braces #5885
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriPerkkio
reviewed
Jun 14, 2024
AriPerkkio
reviewed
Jun 14, 2024
Build is now passing but there's an actual test failure. Maybe some change added some unicode characters?
|
AriPerkkio
force-pushed
the
lint/require-curly
branch
from
June 16, 2024 10:20
06e9728
to
4ed2c5b
Compare
AriPerkkio
reviewed
Jun 16, 2024
@AriPerkkio can you update coverage tests? Since some lines have changed, snapshots and tests themselves (after snapshot update) are now failing |
sheremet-va
force-pushed
the
lint/require-curly
branch
from
June 16, 2024 15:42
6bcb8f9
to
92c85b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made curly braces required as discussed with the team. Eslint doesn't support autofix for this, so I run prettier and eslint on top of it 👀
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.