Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sveltekit example #548

Closed
wants to merge 9 commits into from
Closed

feat: sveltekit example #548

wants to merge 9 commits into from

Conversation

PuruVJ
Copy link
Contributor

@PuruVJ PuruVJ commented Jan 16, 2022

Sveltekit example.

Works on Stackblitz too https://stackblitz.com/edit/puruvj-vitest-bbl3di?file=.stackblitzrc (Screenshot thanks to @userquin )
image

ATM, have to use https://github.com/nickbreaton/vitest-svelte-kit because of how sveltekit digests the vite config into itself.

Would love to know maintainers' opinions on using an external lib

@netlify
Copy link

netlify bot commented Jan 16, 2022

✔️ Deploy Preview for vitest-dev ready!

🔨 Explore the source changes: af24a2e

🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/61e410a41f2b1000071fa913

😎 Browse the preview: https://deploy-preview-548--vitest-dev.netlify.app

@PuruVJ PuruVJ marked this pull request as draft January 16, 2022 13:16
@patak-dev
Copy link
Member

patak-dev commented Jan 16, 2022

For reference, we discussed in https://chat.vitest.dev, See this thread and this discussion. @benmccann, @dominikg, and others are working to make SvelteKit more friendly to projects like Vitest (making it closer to a Vite plugin instead of a wrapper). Dominik suggested we should wait for this refactor to finish before adding this example to the examples

@sheremet-va
Copy link
Member

Are there any news for this PR? 😄

@benmccann
Copy link
Contributor

We're adding experimental Vitest support to SvelteKit here: sveltejs/kit#5094

@benmccann
Copy link
Contributor

@sveltejs/kit/experimental/vite has been released in @sveltejs/kit version 1.0.0-next.353. It'd be great if you're able to update this PR to use the new official support. Feedback welcome in sveltejs/kit#5184. Assuming we get a few people giving positive feedback and there are no major issues, we'd like to take it out of experimental before long

@PuruVJ
Copy link
Contributor Author

PuruVJ commented Jun 24, 2022

Happy to update PR.

Im having some git issues, so might close this and open a new PR and link it here

@PuruVJ PuruVJ closed this Jun 25, 2022
@PuruVJ
Copy link
Contributor Author

PuruVJ commented Jun 25, 2022

#1542

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants