fix: Prevent merging of poolOptions
#5221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.
|
penalosa
changed the title
poolOptionspoolOptions
|
Can you add a test case in test/config? |
I added one in |
I wrote the comment when there were no tests. I suggest adding a test somewhere here: https://github.com/vitest-dev/vitest/blob/main/test/config/test/resolution.test.ts |
|
@sheremet-va I've added a test to that file now |
|
Looks like this PR breaks other config options: https://github.com/vitest-dev/vitest/actions/runs/7932413357/job/21658846975?pr=5221 |
sheremet-va
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Arrays in poolOptions are merged with themselves, resulting in duplicating the entries. This PR fixes that, by ensuring
poolOptionsis not present in the config being merged. Bug repro at https://github.com/penalosa/vitest-custom-pool-repro (just clone and run ./test.sh to see the contents of the array option being duplicated),See solidjs/vite-plugin-solid#101 for a similar fix
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test:ci.Documentation
Changesets