Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(coverage): don't crash when re-run removes earlier run's reports #5022

Merged
merged 1 commit into from
Jan 26, 2024
Merged

fix(coverage): don't crash when re-run removes earlier run's reports #5022

merged 1 commit into from
Jan 26, 2024

Conversation

AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Jan 21, 2024 •
edited
Loading

Description

Before and after videos below. Reading of coverage results from coverage/.tmp is intentionally delayed here so that a single read takes 1s. Test re-run is triggered with enter-key during file reading:

Before
coverage-re-run-before.mov
After
coverage-re-run-after.mov

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify Netlify
Copy link

netlify bot commented Jan 21, 2024 •
edited
Loading

✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit 415a9e8
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65b27b4df966750008a0102b

@AriPerkkio AriPerkkio force-pushed the fix/coverage-files-removed-on-rerun branch from 2138cc4 to fa1a924 Compare January 21, 2024 15:35
@AriPerkkio AriPerkkio marked this pull request as ready for review January 21, 2024 17:41
@AriPerkkio AriPerkkio force-pushed the fix/coverage-files-removed-on-rerun branch from fa1a924 to 415a9e8 Compare January 25, 2024 15:16
@AriPerkkio AriPerkkio requested a review from hi-ogawa January 25, 2024 15:37
hi-ogawa
hi-ogawa approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sheremet-va sheremet-va merged commit 6689856 into vitest-dev:main Jan 26, 2024
19 checks passed
@AriPerkkio AriPerkkio deleted the fix/coverage-files-removed-on-rerun branch January 26, 2024 13:59
@renovate renovate bot mentioned this pull request Feb 27, 2024
Open
1 task
@C0ZEN C0ZEN mentioned this pull request Jun 17, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheremet-va sheremet-va sheremet-va approved these changes

@hi-ogawa hi-ogawa hi-ogawa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No such file or directory for coverage files
3 participants
@AriPerkkio @hi-ogawa @sheremet-va