Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expect): implement chai inspect for AsymmetricMatcher #4942

Merged

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Jan 12, 2024

Description

By implementing custom "inspect" method, it can improve AssertionError.message generated by chai/loupe.

In terms of Jest feature parity, it's difficult to compare because Jest doesn't seem to show the detail in the "message". I tested a same example on jest and its output is like this:

https://stackblitz.com/edit/github-o6sfsk?file=tests%2Fjest.test.cjs

    Message:
      expect(received).toEqual(expected) // deep equality   //// <-- jest is super simple here  
    
    Expected: myStringContaining<xx>
    Received: "hello"

    Difference:

    Compared values have no visual difference.Error:

      21 |
      22 | test("custom error 1", () => {
    > 23 |   expect("hello").toEqual(expect.myStringContaining("xx"));
         |                   ^
      24 | });

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit 555324e
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65a534cf3b515800080d8354
😎 Deploy Preview https://deploy-preview-4942--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa hi-ogawa marked this pull request as ready for review January 13, 2024 01:36
@sheremet-va sheremet-va changed the title feat(expect): implement chai inspect for AsymmetricMatcher fix(expect): implement chai inspect for AsymmetricMatcher Jan 15, 2024
@sheremet-va sheremet-va merged commit 06bae4d into vitest-dev:main Jan 15, 2024
19 checks passed
@hi-ogawa hi-ogawa deleted the feat-asymmetric-matcher-loupe-inspect branch January 17, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants