-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(expect): implement chai inspect for AsymmetricMatcher
#4942
Merged
sheremet-va
merged 10 commits into
vitest-dev:main
from
hi-ogawa:feat-asymmetric-matcher-loupe-inspect
Jan 15, 2024
Merged
fix(expect): implement chai inspect for AsymmetricMatcher
#4942
sheremet-va
merged 10 commits into
vitest-dev:main
from
hi-ogawa:feat-asymmetric-matcher-loupe-inspect
Jan 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fastidious-cascaron-4ded94 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sheremet-va
approved these changes
Jan 12, 2024
sheremet-va
changed the title
feat(expect): implement chai inspect for
fix(expect): implement chai inspect for Jan 15, 2024
AsymmetricMatcher
AsymmetricMatcher
sheremet-va
approved these changes
Jan 15, 2024
6 tasks
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
toThrow
error message but that's not addressed in this PRBy implementing custom "inspect" method, it can improve
AssertionError.message
generated by chai/loupe.In terms of Jest feature parity, it's difficult to compare because Jest doesn't seem to show the detail in the "message". I tested a same example on jest and its output is like this:
https://stackblitz.com/edit/github-o6sfsk?file=tests%2Fjest.test.cjs
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.