fix(vitest): test deep dependencies change detection

[blake-newman]

--changed flag is not correctly looking up deep dependencies, as such the changed flag does not trigger specs if a sub dependency is changed.

Alters the logic to add the collected dependency after recursive addImports is called, otherwise the logic returns early because that dependency has already been added to the collected deps set. So it will not look deeply.

Resolves #4933
(Also Resolves #5009)

[netlify]

✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name	Link
🔨 Latest commit	89678fc
🔍 Latest deploy log	https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65aa529760ee3400086f6841

[hi-ogawa]

Thanks for the PR! (also reproduction and your analysis are awesome!)

This looks like a bug to me since the same logic is also used for vitest related https://vitest.dev/guide/cli.html#vitest-related and it also misses deep dependency. I checked it based on your repro https://stackblitz.com/edit/github-ndav2w?file=package.json

For the sake of verifying this PR, I don't think setting up new tests for --changed is necessary (actually there seems none currently probably because it's tedious to setup git), but It would be great if you can expand existing tests in test/changed/fixtures/related to show that deep dependencies is covered.

[sheremet-va]

Let's add a test case for this change. The tests for this feature are located in test/changed

[blake-newman]

@sheremet-va @hi-ogawa i've added the relevant tests (including imports / re-export syntax).

I also tested locally to ensure that the specs fail if the changes are not applied.

[hi-ogawa]

Looks good!