Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default --open to !process.env.CI #4477

Merged
merged 1 commit into from
Nov 12, 2023
Merged

fix: default --open to !process.env.CI #4477

merged 1 commit into from
Nov 12, 2023

Conversation

collinstevens
Copy link
Contributor

@collinstevens collinstevens commented Nov 11, 2023

Description

When running in CI, vitest will try to open the UI if you pass -ui because --open is defaulting to true even though it says it should default to !process.env.CI.

.option('--open', 'Open UI automatically (default: !process.env.CI))')

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

very odd behavior where if in CI, vitest will try to open the UI
Copy link

netlify bot commented Nov 11, 2023

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit cbd1b66
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/654f69775989160008e64c9f
😎 Deploy Preview https://deploy-preview-4477--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va sheremet-va merged commit 088a047 into vitest-dev:main Nov 12, 2023
13 of 16 checks passed
@collinstevens collinstevens deleted the patch-1 branch January 29, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants