feat: use child_process for --no-threads #1790
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@antfu this is just an idea for now, tell me what you think 👀 Most of the things are not optimized. For example, flow (https://github.com/avajs/ava/blob/main/lib/ipc-flow-control.cjs) and serializaton/deserelization with v8 can be improved. Also, these processes are firing up really slowly, haven't check why yet 👀 |
|
The fix for workers already exist for Node 18, the fix for Node 16 will land on August 16th (nodejs/node#44098). It was also backported to v14, but wasn't released yet, I think. I guess we can close this PR 😄 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible solution for running tests in child_process, if your tests are failing with v8 segfault.