Skip to content

Commit

Permalink
chore: update types/node and run tests on Node 22 (#6437)
Browse files Browse the repository at this point in the history
  • Loading branch information
sheremet-va committed Sep 12, 2024
1 parent 2ea31d3 commit 5341a55
Show file tree
Hide file tree
Showing 5 changed files with 118 additions and 106 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
# Reset back to 20 after https://github.com/nodejs/node/issues/53648
# (The issues is closed, but the error persist even after 20.14)
node_version: [18, 20]
# node_version: [18, 20, 22] 22 when LTS is close enough
node_version: [18, 20, 22]
include:
- os: macos-14
node_version: 20
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"@rollup/plugin-commonjs": "^26.0.1",
"@rollup/plugin-json": "^6.1.0",
"@rollup/plugin-node-resolve": "^15.2.3",
"@types/node": "^20.14.15",
"@types/node": "^22.5.2",
"@types/ws": "^8.5.12",
"@vitest/browser": "workspace:*",
"@vitest/coverage-istanbul": "workspace:*",
Expand Down
2 changes: 1 addition & 1 deletion packages/vitest/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@
"@types/istanbul-reports": "^3.0.4",
"@types/jsdom": "^21.1.7",
"@types/micromatch": "^4.0.9",
"@types/node": "^20.14.15",
"@types/node": "^22.5.2",
"@types/prompts": "^2.4.9",
"@types/sinonjs__fake-timers": "^8.1.5",
"acorn-walk": "^8.3.3",
Expand Down
Loading

0 comments on commit 5341a55

Please sign in to comment.