Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[valid-describe-callback] Fix to support options as second parameter for valid-describe-callback #582

Merged
merged 3 commits into from
Dec 2, 2024
Merged

[valid-describe-callback] Fix to support options as second parameter for valid-describe-callback #582

merged 3 commits into from
Dec 2, 2024

Conversation

y-hsgw
Copy link
Contributor

@y-hsgw y-hsgw commented Dec 2, 2024

Resolves: #542

veritem
veritem approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@veritem veritem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@veritem veritem merged commit a1ef516 into vitest-dev:main Dec 2, 2024
@y-hsgw y-hsgw deleted the fix/valid-describe-callback branch December 2, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veritem veritem veritem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vitest/valid-describe-callback does not support options as second parameter
2 participants
@y-hsgw @veritem