Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(valid-function-names): updated list of possible permutations of call chains #276

Merged
merged 1 commit into from
Oct 22, 2023
Merged

feat(valid-function-names): updated list of possible permutations of call chains #276

merged 1 commit into from
Oct 22, 2023

Conversation

KoenBrouwer
Copy link
Contributor

@KoenBrouwer KoenBrouwer commented Oct 21, 2023

I updated the list of all possible call chains with all possible permutations up to 3 levels deep. I added bench as per the docs. I also removed Jest-like calls that are not supported by Vitest, like fit, xit, xdescribe, and fdescribe.

Because the list has grown quite a bunch, I moved it into its own separate file.

I also cherry picked a few chains to add to your tests. I only added a few since the tests already didn't cover every single possibility.

FYI: I used a script to create the list. See https://gist.github.com/KoenBrouwer/e1df9ff68d0a3fc2d98f34a1d23f41a6.

Fixes #275

@KoenBrouwer KoenBrouwer marked this pull request as ready for review October 21, 2023 14:49
Copy link
Member

@veritem veritem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot of work

Thank you!!!

@veritem veritem merged commit 5375f2e into vitest-dev:main Oct 22, 2023
@KoenBrouwer KoenBrouwer deleted the feature/275 branch October 23, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-standalone-expect] False positive inside it.fails
2 participants