Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: multi-metrics throttler #1786

Merged
merged 17 commits into from
Jul 15, 2024
Merged

Docs: multi-metrics throttler #1786

merged 17 commits into from
Jul 15, 2024

Conversation

shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Jul 11, 2024

This documents the changes made in vitessio/vitess#15988. It is a major rewrite of the tablet throttler page.

No point in reviewing the diff due to this massive rewrite. Just head to the preview page: https://deploy-preview-1786--vitess.netlify.app/docs/21.0/reference/features/tablet-throttler/

Tracking issue: vitessio/vitess#15624

Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit 5d8bd09
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/66953b6e384f5f000823f6ee
😎 Deploy Preview https://deploy-preview-1786--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shlomi-noach shlomi-noach requested a review from a team July 11, 2024 04:32
Copy link
Collaborator

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Thank you! I only had minor suggestions.

shlomi-noach and others added 14 commits July 15, 2024 16:45
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
…bout not having to configure heartbeat

Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
@mattlord
Copy link
Collaborator

Looks good! One nit:
of Keyspace. in the topo service

Recommendation:
of the Keyspace record in the topo service

Signed-off-by: Shlomi Noach <[email protected]>
@shlomi-noach
Copy link
Contributor Author

of Keyspace. in the topo service

Fixed

@shlomi-noach shlomi-noach merged commit 4086e7d into prod Jul 15, 2024
5 checks passed
@shlomi-noach shlomi-noach deleted the docs-throttler-multi-metrics branch July 15, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants