Update VTOrc flags to include --change-tablets-with-errant-gtid-to-drained
#1574
Conversation
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| | --clusters_to_watch | strings | Comma-separated list of keyspaces or keyspace/shards that this instance will monitor and repair. Defaults to all clusters in the topology. Example: "ks1,ks2/-80" | | ||
| | --config | string | config file name | | ||
| | --consul_auth_static_file | string | JSON File to read the topos/tokens from. | | ||
| | --convert-tablets-with-errant-gtids | boolean | Whether VTOrc should be changing the type of the tablets with errant GTIDs to `DRAINED` | |
There was a problem hiding this comment.
Goland reformats the table, but only this line has been added.
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Manan Gupta <[email protected]>
| @@ -26,81 +26,82 @@ vtorc \ | |||
|
|
|||
| The following command line options apply to VTOrc: | |||
There was a problem hiding this comment.
do we want to just link to the reference page now?
(and update those via make vtorc-docs, see vitessio/vitess#13918
There was a problem hiding this comment.
This is the reference page, right?
I updated it manually, but I guess I can use the make vtorc-docs command to copy over from now on?
There was a problem hiding this comment.
shoot, i meant https://vitess.io/docs/18.0/reference/programs/vtorc/, which is now autogenerated from cobra
There was a problem hiding this comment.
Gotcha, I'll refactor this PR 👍
There was a problem hiding this comment.
I get this error when I try to run the make command -
VITESS_DIR=/Users/manangupta/vitess make vtorc-docs
go run ./tools/cobradocs/ --vitess-dir "/Users/manangupta/vitess" --version-pairs ""main:16.0,v15.0.2:15.0"" vtorc
2023/09/14 12:08:43 cannot find directory for doc version main:16.0 (index=0): stat /Users/manangupta/website/content/en/docs/16.0/reference/programs/vtorc: no such file or directory
exit status 1
make: *** [vtorc-docs] Error 1
There was a problem hiding this comment.
Now I am getting this error 😢
VITESS_DIR=/Users/manangupta/vitess COBRADOC_VERSION_PAIRS="HEAD:18.0" make vtorc-docs
go run ./tools/cobradocs/ --vitess-dir "/Users/manangupta/vitess" --version-pairs "HEAD:18.0" vtorc
2023/09/18 09:30:49 exit status 1
exit status 1
make: *** [vtorc-docs] Error 1
There was a problem hiding this comment.
rebase on prod so the content/en/docs/18.0/reference/programs/vtorc directory exists (there's a --debug flag you can manually add to the binary, btw)
There was a problem hiding this comment.
I just saw that main already has the flag changes for that directory because of #1583. I'll close this PR now. Thanks for all the help.
There was a problem hiding this comment.
oh sorry about that! those diffs get kinda big so i didn't notice to point it out :/
deepthi
changed the title
--convert-tablets-with-errant-gtids--change-tablets-with-errant-gtid-to-drained
This PR adds the docs for the PR vitessio/vitess#13873