Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Getting Started to include vtadmin link. #1393

Merged
merged 3 commits into from
Feb 24, 2023

Conversation

andylim-duo
Copy link
Contributor

Description

This PR updates the Getting Started documentation for the Local Install Via Docker page. This update is related to PR #12467 on the vitess project.

Testing

The update was manually verified and shown in the screen capture below:

The-Vitess-Docs-Local-Install-via-Docker

@netlify
Copy link

netlify bot commented Feb 24, 2023

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit 8e849c1
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/63f8da8f9879760008a47adc
😎 Deploy Preview https://deploy-preview-1393--vitess.netlify.app/docs/14.0/get-started/local-docker
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do you mind making the same change on the v14, v15, and v17 pages too?

@andylim-duo
Copy link
Contributor Author

LGTM! Do you mind making the same change on the v14, v15, and v17 pages too?

Sure thing. I'll update those versions.

Copy link
Collaborator

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ @notfelineit, can you please take a look too?

Copy link
Contributor

@notfelineit notfelineit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 great work

@notfelineit notfelineit merged commit 9fe4305 into vitessio:prod Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants