Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed v16 internal links #1360

Merged
merged 9 commits into from
Jan 28, 2023
Merged

fixed v16 internal links #1360

merged 9 commits into from
Jan 28, 2023

Conversation

PaarthAgarwal
Copy link
Contributor

@PaarthAgarwal PaarthAgarwal commented Jan 25, 2023

Fixed v16 internal links and target hashes. Partially fixes #1170.

@nate-double-u
Copy link
Collaborator

Thanks for this @PaarthAgarwal, please sign the DCO -- this repository requires each commit to be signed before we merge. You can find the instructions here: https://github.com/vitessio/website/pull/1360/checks?check_run_id=10883304143

@netlify
Copy link

netlify bot commented Jan 25, 2023

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit 136fa91
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/63d3a9023915d8000c9e60dd
😎 Deploy Preview https://deploy-preview-1360--vitess.netlify.app/docs/16.0/reference/features/vindexes
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nate-double-u
Copy link
Collaborator

I've approved the preview, so you can see the preview here: https://deploy-preview-1360--vitess.netlify.app/

rohit-nayak-ps and others added 7 commits January 26, 2023 16:05
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: PaarthAgarwal <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: PaarthAgarwal <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: PaarthAgarwal <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: PaarthAgarwal <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: PaarthAgarwal <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: PaarthAgarwal <[email protected]>
Signed-off-by: PaarthAgarwal <[email protected]>
@PaarthAgarwal
Copy link
Contributor Author

Finally signed off. Had to regenerate my personal access token but worth it haha

@PaarthAgarwal PaarthAgarwal marked this pull request as ready for review January 26, 2023 12:08
content/en/docs/16.0/reference/features/vindexes.md Outdated Show resolved Hide resolved
@nate-double-u
Copy link
Collaborator

Finally signed off. Had to regenerate my personal access token but worth it haha

Thanks for doing that! Should be easier now for your next PRs 🙂

Signed-off-by: Paarth Agarwal <[email protected]>
Copy link
Collaborator

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, @PaarthAgarwal ! ❤️

@mattlord mattlord merged commit 97f8279 into vitessio:prod Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken internal links - v16
5 participants