-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add vtbackup reference and refactor backup/restore docs #1351
Conversation
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: Max Englander <[email protected]>
Signed-off-by: Max Englander <[email protected]>
193da64
to
12f1cf1
Compare
Signed-off-by: Max Englander <[email protected]>
12f1cf1
to
3570f02
Compare
@@ -0,0 +1,232 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually have another PR for vtbackup .. but I will go through yours and if needed will close mine ..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have another one feel free to go with that and close this one! I have no preference, whichever you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good.. There are few deprecation in the flags but I have taken care of it in another PR (https://github.com/vitessio/website/pull/1330/files)... once you push this change .. I will apply my PR on top of it.
- Alerting human operators if the failure is persistent. | ||
|
||
## Example Usage | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: Consider you have running Vitess cluster, the following command will create backup of keyspace commerce
having shard 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have taken care of this in my PR.
Accompanies vitessio/vitess#11979.
In order to document all of the new metrics introduced by vitessio/vitess#11979, I would like to be able to talk about
vtbackup
. Currently the docs don't mentionvtbackup
at all. This PR reorganizes adds a reference page for vtbackup and re-organizes the backup/restore docs a bit to make it easier to talk aboutvtbackup
.