Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document MySQL 8.0.30+ backup limitations #1129

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Conversation

mattlord
Copy link
Collaborator

@mattlord mattlord commented Aug 3, 2022

You can see the changes from here:

You can use the left hand navigation to see the 3 backup and restore pages. You can change the version number in the URL to see the changes for 13.0 and 14.0 (15.0 needs none as it will support 8.0.30 in all releases).

@vitess-bot
Copy link
Contributor

vitess-bot bot commented Aug 3, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@netlify
Copy link

netlify bot commented Aug 3, 2022

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit 469568f
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/62ea9d15d419290009e58094
😎 Deploy Preview https://deploy-preview-1129--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mattlord mattlord marked this pull request as ready for review August 3, 2022 16:10
@mattlord mattlord requested review from deepthi, dweitzman and GuptaManan100 and removed request for dweitzman August 3, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants