evalengine: More functions! #9673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmg
added
Type: Enhancement
Signed-off-by: Vicent Marti <[email protected]>
Signed-off-by: Vicent Marti <[email protected]>
Signed-off-by: Vicent Marti <[email protected]>
Signed-off-by: Vicent Marti <[email protected]>
Signed-off-by: Vicent Marti <[email protected]>
Signed-off-by: Vicent Marti <[email protected]>
vmg
force-pushed
the
evalengine-more-fn
branch
from
350c259
to
1f95837
Compare
GuptaManan100
approved these changes
Feb 11, 2022
There was a problem hiding this comment.
All the changes look good to me. The shift-reduce conflict in the parser is unavoidable because we have a catch-all statement for functions in the end. Until, we remove it, any function which is a non-reserved keyword will have shift-reduce conflicts.
However, the check_make_parser.sh has to be fixed to expect a conflict
Signed-off-by: Vicent Marti <[email protected]>
Signed-off-by: Vicent Marti <[email protected]>
Signed-off-by: Vicent Marti <[email protected]>
systay
reviewed
Feb 11, 2022
systay
reviewed
Feb 11, 2022
| @@ -86,6 +86,8 @@ func TestConvertSimplification(t *testing.T) { | |||
| {"coalesce(NULL, 2, NULL, 4)", ok("COALESCE(NULL, INT64(2), NULL, INT64(4))"), ok("INT64(2)")}, | |||
| {"coalesce(NULL, NULL)", ok("COALESCE(NULL, NULL)"), ok("NULL")}, | |||
| {"coalesce(NULL)", ok("COALESCE(NULL)"), ok("NULL")}, | |||
| {"weight_string('foobar')", ok(`WEIGHT_STRING(VARCHAR("foobar"))`), ok(`VARBINARY("\x00F\x00O\x00O\x00B\x00A\x00R")`)}, | |||
| {"weight_string('foobar' as char(12))", ok(`WEIGHT_STRING(VARCHAR("foobar") AS CHAR(12))`), ok(`VARBINARY("\x00F\x00O\x00O\x00B\x00A\x00R\x00 \x00 \x00 \x00 \x00 \x00 ")`)}, | |||
There was a problem hiding this comment.
shouldn't we also add the bit operations to this test?
There was a problem hiding this comment.
The bit operations are integration tested in the major suite.
systay
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hot off the press! New functionality for the
evalengine. This PR implements and tests:WEIGHT_STRING: useful to ensure our collations implementation is actually working (spoiler: it is). This includes some changes to the sqlparser becauseWEIGHT_STRINGhas special syntax.!operator (which is an alias forNOT)&,|,^,<<,>>,~, andBIT_COUNTbit-wise operatorsRelated Issue(s)
Checklist
Deployment Notes