gen4: Add hash join primitive and planning #9140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
force-pushed
the
hash-join
branch
from
aba6d46
to
719507b
Compare
Signed-off-by: Andres Taylor <[email protected]>
systay
added
Component: Query Serving
release notes
Type: Enhancement
Signed-off-by: Andres Taylor <[email protected]>
GuptaManan100
approved these changes
Nov 9, 2021
frouioui
approved these changes
Nov 9, 2021
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
systay
commented
Nov 16, 2021
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
frouioui
reviewed
Nov 16, 2021
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
|
We should hide this behind a planner hint until we are comfortable with it being used |
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
we can now use the |
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
harshit-gangal
approved these changes
Nov 17, 2021
Signed-off-by: Vicent Marti <[email protected]>
Signed-off-by: Vicent Marti <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Comment on lines
+224
to
+228
| typ, err := CoerceTo(v1.Type(), v2.Type()) // TODO systay we should add a method where this decision is done at plantime | ||
| if err != nil { | ||
| return 0, err | ||
| } | ||
| v1cast, err := castTo(v1, typ) |
There was a problem hiding this comment.
based on the TODO,
what can at least be done is to pass the coerceTo value directly to the NullsafeCompare method and calculate that once in the engine.
Signed-off-by: Andres Taylor <[email protected]>
king-11
reviewed
Nov 19, 2021
| @@ -28,37 +28,37 @@ var _ Primitive = (*Distinct)(nil) | |||
|
|
|||
| // Distinct Primitive is used to uniqueify results | |||
| type Distinct struct { | |||
| Source Primitive | |||
| Source Primitive | |||
| ColCollations []collations.ID | |||
There was a problem hiding this comment.
We can use a map over here which can simplify the access and also prevent any index out of range errors easily.
There was a problem hiding this comment.
when executing things in the runtime, we want them as fast as possible. A map is actually slower than accessing a position by offset in a slice, so I'll keep the collations as a slice here
Signed-off-by: Andres Taylor <[email protected]>
…y on the hint for now Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds hash joins to the alternatives that the gen4 planner can use when planning queries.
The current join algorithm is a nested loop join, also known as an Apply Join. It will run the query on the RHS of the join as many times as there are rows on the LHS. The complexity is
O(n*m). Hash Join will only run each query once, so the complexity isO(n+m)Related Issue(s)
#7280
Checklist