Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semi join review comments and bug fixes #9083

Merged
merged 4 commits into from
Oct 26, 2021
Merged

Semi join review comments and bug fixes #9083

merged 4 commits into from
Oct 26, 2021

Conversation

GuptaManan100
Copy link
Member

Description

This PR handles the review comments posted on #9039 after it was merged.

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@GuptaManan100 GuptaManan100 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving release notes none labels Oct 26, 2021
@GuptaManan100 GuptaManan100 mentioned this pull request Oct 26, 2021
Merged
3 tasks
@harshit-gangal harshit-gangal merged commit a1fcbe4 into vitessio:main Oct 26, 2021
@harshit-gangal harshit-gangal deleted the semi-join-review-comments branch October 26, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuptaManan100 @harshit-gangal