Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper handling of CHAR columns with binary collations #8730

Merged
merged 5 commits into from
Oct 7, 2021
Merged

Proper handling of CHAR columns with binary collations #8730

merged 5 commits into from
Oct 7, 2021

Commits on Oct 5, 2021

  1. VReplication: testing CHAR with binary collation 

    Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
    @shlomi-noach @mattlord
    shlomi-noach authored and mattlord committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    6f84711 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2021

  1. Trim padding added on CHAR columns with BINARY collations 

    We need to take the max bytes per character into account
or we try to insert too many characters into the fixed
length column.

Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    fe9ed55 View commit details
    Browse the repository at this point in the history

  2. Try to do the padding correctly rather than adjust/trim later 

    If we do the padding higher in the call stack then we have the
column schema, which includes the character set, that we can use
to do the padding correctly.

Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    8b5a319 View commit details
    Browse the repository at this point in the history

  3. Revert "Try to do the padding correctly rather than adjust/trim later" 

    There's some test failures that I don't fully understand -- this
method is cauing VDiffs to fail, along with the onlineddl_vrepl
varbinary test.

Reverting to the post-trim method as it now seems safer -- if less
elegant.

Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    639acae View commit details
    Browse the repository at this point in the history

  4. Add safety check to ensure we're not trimming non-null bytes 

    And also ensure that both the value and the column type binary

Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    0d673c5 View commit details
    Browse the repository at this point in the history