Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gen4: Derived tables #8491

Merged
merged 37 commits into from
Jul 28, 2021
Merged

gen4: Derived tables #8491

merged 37 commits into from
Jul 28, 2021

Conversation

systay
Copy link
Collaborator

@systay systay commented Jul 19, 2021 •
edited
Loading

Description

Adds support for derived tables in gen4.

Related Issue(s)

#7280

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

GuptaManan100 and others added 7 commits July 20, 2021 12:20
@systay systay added Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Jul 20, 2021
@systay
fix bad merge and test comments
7258ad3 
Signed-off-by: Andres Taylor <[email protected]>
@systay
more work on derived tables
4f7e45c 
Signed-off-by: Andres Taylor <[email protected]>
@systay systay marked this pull request as ready for review July 22, 2021 14:24
@systay
goto is considered harmful
b730c5c 
Signed-off-by: Andres Taylor <[email protected]>
@systay
fixed test assertions
109c08b 
Signed-off-by: Andres Taylor <[email protected]>
frouioui
frouioui approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request looks good to me, I have left a couple of comments

go/vt/vtgate/planbuilder/jointree.go Outdated Show resolved Hide resolved
go/vt/vtgate/planbuilder/jointree.go Outdated Show resolved Hide resolved
@systay systay marked this pull request as draft July 22, 2021 23:02
@frouioui frouioui marked this pull request as ready for review July 27, 2021 08:06
GuptaManan100
GuptaManan100 approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! 🏎️

systay and others added 3 commits July 28, 2021 10:16
@systay
Merge main into gen4-derived
be4c0b6 
Signed-off-by: Andres Taylor <[email protected]>
@harshit-gangal
fix formatting error
16cd198 
Signed-off-by: Harshit Gangal <[email protected]>
@harshit-gangal
code refactor
6d89d0f 
Signed-off-by: Harshit Gangal <[email protected]>
@systay systay merged commit f3c7a2c into vitessio:main Jul 28, 2021
@systay systay deleted the gen4-derived branch July 28, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@deepthi deepthi Awaiting requested review from deepthi

@rafael rafael Awaiting requested review from rafael

Assignees
No one assigned
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@systay @harshit-gangal @frouioui @GuptaManan100