Gen4: extracting routing information from predicates for system tables #8480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshit-gangal
added
Component: Query Serving
Type: Enhancement
… query Signed-off-by: Harshit Gangal <[email protected]>
…ed all system tables plan tests into its own file Signed-off-by: Harshit Gangal <[email protected]>
…e them to validate that all the tables points to same keyspace routing Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
harshit-gangal
force-pushed
the
gen4-dba-tables
branch
from
5d4beac
to
38f506b
Compare
…ault keyspace is not set Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
frouioui
approved these changes
Jul 19, 2021
Comment on lines
+472
to
+475
| ksName := "" | ||
| if vschema.keyspace != nil { | ||
| ksName = vschema.keyspace.Name | ||
| } |
There was a problem hiding this comment.
We can probably extract this. We use the same snippet in three different places
…re not information_schema queries Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
systay
reviewed
Jul 20, 2021
| @@ -95,6 +97,10 @@ type ( | |||
|
|
|||
| // columns needed to feed other plans` | |||
| columns []*sqlparser.ColName | |||
|
|
|||
| // The following two fields are used when routing information_schema queries | |||
| SysTableTableSchema []evalengine.Expr | |||
There was a problem hiding this comment.
hmm... we are using sqlparser.Expr for predicates here. feels icky to mix both parser stuff and evalengine stuff in the same struct. would it make sense to keep this as AST elements and turn them into evalengine thingies in the jointree_transformers?
systay
approved these changes
Jul 20, 2021
|
Will address review comments in following PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for information_schema queries in Gen4. This also works if CNF rewriting is required.
Related Issue(s)
#7280
Checklist
Deployment Notes