Gen4: Distinct #8479
Merged
Gen4: Distinct #8479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: Andres Taylor <[email protected]> Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: Andres Taylor <[email protected]> Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: Andres Taylor <[email protected]> Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: Andres Taylor <[email protected]> Signed-off-by: Florent Poinsard <[email protected]>
systay
added
Component: Query Serving
Type: Enhancement
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
frouioui
approved these changes
Jul 15, 2021
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
harshit-gangal
approved these changes
Jul 16, 2021
Comment on lines
+223
to
+231
| err = hp.truncateColumnsIfNeeded() | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| if hp.qp.NeedsDistinct() { | ||
| hp.plan, err = pushDistinct(hp.plan, hp.semTable, hp.vschema, hp.qp) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
can add TODO for supporting collation in distinct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds DISTINCT planning to the gen4 planner
Related Issue(s)
Tracking #7280
Checklist