Online DDL/Vreplication suite: fix test for no shared UK #8334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <[email protected]>
…future we may extend to _any uk_ Signed-off-by: Shlomi Noach <[email protected]>
shlomi-noach
added
Type: Enhancement
|
converting to draft while investigating impact onto another test |
Signed-off-by: Shlomi Noach <[email protected]>
|
issue fixed. Ready for review. |
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
|
ping for review |
vmg
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we add and fix the test
fail-no-shared-ukwhere the migration fails if there's no exact match between PK columns in before/after tables.Note that we currently expect both before/after tables to have same set of columns covered by
PRIMARY KEY. In the future, we will relax the constraint and allow for any shared non-nullUNIQUE KEY.Related Issue(s)
Checklist