Online DDL/VReplication suite: reject non utf8* charsets #8278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
|
This is not ready yet |
|
I'm actually working to make non-utf8 work. Only blocker right now is conversion ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now Vitess only supports
utf8*characters sets, per https://vitess.io/docs/reference/compatibility/mysql-compatibility/#character-set-and-collationWhile schemas pass through, schema changes with non
utf8*charsets will not work in VReplication. For this reason, we rejects changes where tables have nonutf8*textual columns. This PR imports and modifies a online DDL/VReplication suite test, from thegh-ostsuite.Will possibly try to fix that in VReplication later on.
Related Issue(s)
#8181
Checklist
Deployment Notes