Revert "backup: Use pargzip instead of pgzip for compression." #8174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d2f2d09. Signed-off-by: Rafael Chacon <[email protected]>
deepthi
approved these changes
May 24, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts PR #7037. It introduced significant performance regressions. Backups are taking twice as long with this change. Per discussion in Slack, we will revert this in 9.0 and fix forward with #7978 where the decompressor will be configurable. That way users can choose the compression algorithm that makes more sense for their environment.
Signed-off-by: Rafael Chacon [email protected]