Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AST helper generation #7558

Merged
merged 42 commits into from
Mar 2, 2021
Merged

Update AST helper generation #7558

merged 42 commits into from
Mar 2, 2021

Commits on Feb 12, 2021

  1. it's a start 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    71482a7 View commit details
    Browse the repository at this point in the history

  2. apply pre- and post-switch 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    4cbdb20 View commit details
    Browse the repository at this point in the history

  3. switch 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    08e38d9 View commit details
    Browse the repository at this point in the history

  4. extracted rewriter code to own file 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    0a1992e View commit details
    Browse the repository at this point in the history

  5. visit struct fields that implement the interface 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    05b0af3 View commit details
    Browse the repository at this point in the history

  6. support field with struct type 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    d72873d View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2021

  1. extracted rewriter generation into its own file 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    9290991 View commit details
    Browse the repository at this point in the history

  2. added replacer methods 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    9c3dc09 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2021

  1. support interface implementations that are not pointers 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    e2d23e2 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2021

  1. add replacement methods for array fields 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    98e4e5b View commit details
    Browse the repository at this point in the history

  2. added case statements for slice fields 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    5c93919 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. Addition of panic of value type implementation 

    Signed-off-by: Florent Poinsard <[email protected]>
    @frouioui
    frouioui committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    2d66e2e View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2021

  1. asthelpergen: improve integration tests 

    Signed-off-by: Andres Taylor <[email protected]>
    @vmg @systay
    vmg authored and systay committed Feb 20, 2021
    Configuration menu
    Copy the full SHA
    999a36f View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2021

  1. better tests 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    21e902c View commit details
    Browse the repository at this point in the history

  2. benchmark for slice replacer 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    7af230c View commit details
    Browse the repository at this point in the history

  3. nicer replacement methods for slices 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    7b5f171 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2021

  1. Added replacer and cases for InterfaceSlice 

    Signed-off-by: GuptaManan100 <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    0116a12 View commit details
    Browse the repository at this point in the history

  2. moved code away from the generated file 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    c3c68be View commit details
    Browse the repository at this point in the history

  3. support slices of non-AST elements 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    0fb0313 View commit details
    Browse the repository at this point in the history

  4. use the new rewriter 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    3f43634 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/master' into visitorgen-rewrite3 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    34c6502 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. refactored and addressed review comments 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    f2d4e68 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into visitorgen-rewrite3 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    99b6ac0 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2021

  1. Add deep clone capability to ASThelpergen 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    ffe3527 View commit details
    Browse the repository at this point in the history

  2. added support for basic types that implement interfaces 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    725fcd5 View commit details
    Browse the repository at this point in the history

  3. handle interface{} fields 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    e2dc629 View commit details
    Browse the repository at this point in the history

  4. final touch ups. produce the clone.go file for the AST 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    044b550 View commit details
    Browse the repository at this point in the history

  5. code clean up; minor change for interface clone methods 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    b42085d View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2021

  1. make the clone methods use less memory 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    b79366a View commit details
    Browse the repository at this point in the history

  2. added comment to clone methods 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    858859e View commit details
    Browse the repository at this point in the history

  3. Added the option to excempt types from clone generation 

    Because of how semantic analysis works, we need the cloned AST to keep the
ColName references in the tree. These are tied to the semantic state, and if
we create new objects, we loose the dependency infornation we gathered during
semantic analysis.

Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    46c42d4 View commit details
    Browse the repository at this point in the history

  4. remove the hand written clone and start using the generated one 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    dc14a65 View commit details
    Browse the repository at this point in the history

  5. inline replacer methods for the rewriter 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    09f3f0b View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/master' into deep-clone 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    fce3959 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. made nextval as reference type in ast 

    Signed-off-by: Harshit Gangal <[email protected]>
    @harshit-gangal
    harshit-gangal committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    aa88caf View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2021

  1. dry 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    3e95345 View commit details
    Browse the repository at this point in the history

  2. simplify the function used to visit slice elements 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    f4036ca View commit details
    Browse the repository at this point in the history

  3. simplify the rewriter some more 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    cd7c4b3 View commit details
    Browse the repository at this point in the history

  4. rewriter benchmark 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    f03d4b1 View commit details
    Browse the repository at this point in the history

  5. Revert "simplify the rewriter some more" 

    This reverts commit cd7c4b3.

Turns out this change significantly degrades performance, and we don't want that...

Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    9af91e0 View commit details
    Browse the repository at this point in the history

  6. added error to the return params of Rewrite 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    5488cc6 View commit details
    Browse the repository at this point in the history

  7. return errors instead of panicking 

    Signed-off-by: Andres Taylor <[email protected]>
    @systay
    systay committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    db053f7 View commit details
    Browse the repository at this point in the history