Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gen4: fail unsupported queries #7409

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

systay
Copy link
Collaborator

@systay systay commented Jan 29, 2021

Description

Then Gen4 planner is growing, but there is still a lot of query types that are not supported. This PR makes sure to fail the unsupported cases instead of producing bad plans.

Related Issue(s)

Gen4 tracking #7280

Impacted Areas in Vitess

Components that this PR will affect:

  • [x ] Query Serving

No docs are needed.

@harshit-gangal harshit-gangal marked this pull request as draft March 1, 2021 06:14
@harshit-gangal
Copy link
Member

moved this PR to draft, as there is some more work to do done on this.

@systay systay marked this pull request as ready for review March 2, 2021 15:31
@systay
Copy link
Collaborator Author

systay commented Mar 2, 2021

Cleaned up, squashed and rebased. I think this can go in now

@harshit-gangal harshit-gangal merged commit d35cfc8 into vitessio:master Mar 2, 2021
@harshit-gangal harshit-gangal deleted the gen4-fail branch March 2, 2021 16:29
@askdba askdba added this to the v10.0 milestone Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants