Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vtctld: make cell optional #6111

Merged
merged 2 commits into from
Apr 27, 2020
Merged

vtctld: make cell optional #6111

merged 2 commits into from
Apr 27, 2020

Commits on Apr 26, 2020

  1. vtctld: make cell optional 

    This change makes the cell flag optional for vtctld. This removes
the catch-22 that you have to create a cell before launching vtctld.
But then, how do you create a cell without a vtctld?

This required a one-time use of vtctl tool to create this initial
cell.

If you don't specify a cell, vtctld will choose one at random.
I believe the main use case for this is for identifying which shards
are serving vs. non-serving. This info is now available in global
topo itself as the "IsMasterServing" flag. But, we'll need to
go into the UI to make this change, which is non-trivial right now.

Signed-off-by: Sugu Sougoumarane <[email protected]>
    @sougou
    sougou committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    f342314 View commit details
    Browse the repository at this point in the history

  2. vtctld: use correct API to get cells 

    Also use the API only if localcell is not specified.

Signed-off-by: Sugu Sougoumarane <[email protected]>
    @sougou
    sougou committed Apr 26, 2020
    Configuration menu
    Copy the full SHA
    14a4fa4 View commit details
    Browse the repository at this point in the history