vitess/lite images based on Red Hat UBI 7 #6100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacques Grove <[email protected]>
Signed-off-by: Jacques Grove <[email protected]>
Signed-off-by: Jacques Grove <[email protected]>
aquarapid
requested review from
derekperkins,
dkhenry and
sougou
as code owners
morgo
reviewed
Apr 22, 2020
Comment on lines
+25
to
+26
| # Re-copy sources from working tree. | ||
| COPY --chown=vitess:vitess . /vt/src/vitess.io/vitess |
There was a problem hiding this comment.
I think we should try and clean up the directory structure since src/vitess.io/vitess is no longer required (it was before the repo structure flattened).
morgo
reviewed
Apr 22, 2020
Comment on lines
+22
to
+23
| # Allows some docker builds to disable CGO | ||
| ARG CGO_ENABLED=0 |
There was a problem hiding this comment.
I think we can remove this, but we should maybe check with others?
| ENV VTROOT /vt/src/vitess.io/vitess | ||
| ENV VTDATAROOT /vt/vtdataroot | ||
| ENV PATH $VTROOT/bin:$PATH | ||
| ENV MYSQL_FLAVOR MySQL80 |
There was a problem hiding this comment.
It should be possible to remove MYSQL_FLAVOR. Vitess has been able to autodetect it for a while, but some of the legacy python tests still required it being set.
Signed-off-by: Jacques Grove <[email protected]>
container catalog requirements. Signed-off-by: Jacques Grove <[email protected]>
morgo
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.