Reduce race in legacy_local_example #6076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morgan Tocker <[email protected]>
…local Signed-off-by: Morgan Tocker <[email protected]>
sougou
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race in the local example, where starting vtgate actually waits for the status port to be up, but it seems the MySQL port may come up just a fraction later.
I added a sleep in the local_example, which has actually improved the stability. This adds a sleep in the legacy example, which should similarly improve it.
I know sleeps is not a good solution, and long term it probably makes sense to bring up the status port when the MySQL port is healthy. But that's a solution I've not looked into yet.
Signed-off-by: Morgan Tocker [email protected]