Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the initial sharding flaky test #6043

Merged
merged 1 commit into from
Apr 13, 2020

Conversation

arindamnayak
Copy link
Contributor

@arindamnayak arindamnayak commented Apr 10, 2020

Fix for one more flaky test (which contains Too many connections error):

Error Trace:	base_sharding.go:151
        	            				base_sharding.go:351
        	            				base_sharding.go:323
        	            				sharding_util.go:495
        	Error:      	Expected nil, but got: &mysql.SQLError{Num:2012, State:"HY000", Message:"immediate error from server errorCode=1040 errorMsg=Too many connections", Query:""}
        	Test:       	TestInitialSharding

We were creating multiple connections in loop to insert and verify more than 2000 rows created by sharding test. This might be creating 'Too many connection' error. Now, the connection is created first and then passed around to insert/verify the rows

FYI @deepthi

Signed-off-by: Arindam Nayak [email protected]

We were creating multiple connection in loop to verify more than 2000 rows created by sharding test. This was creating 'Too many connection' error. Now, the connection is created first and then passed around to verify the rows

Signed-off-by: Arindam Nayak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants