VCopier Flaky Test: modify how we validate expected queries #6033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d passed-through queries back to wanted queries Signed-off-by: Rohit Nayak <[email protected]>
rohit-nayak-ps
changed the title
Signed-off-by: Rohit Nayak <[email protected]>
rohit-nayak-ps
changed the title
sougou
approved these changes
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier we either checked for all queries or we ignored all _vt.vreplication and begin/commit/rollback queries. This didn't work well when we wanted to validate certain _vt.vreplication queries.
Now we only ignore spurious update pos transactions and check explicitly for all other _vt.vreplication queries. This also documents the tests better.
Signed-off-by: Rohit Nayak [email protected]