Misc cleanups: Remove deadcode in tests, makefile #5983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morgan Tocker <[email protected]>
Signed-off-by: Morgan Tocker <[email protected]>
Signed-off-by: Morgan Tocker <[email protected]>
morgo
changed the title
|
Currently the docker-based tests are failing because the docker images are using go 1.12. This is fixed in source, but needs the images to be republished. After this is done, all tests should pass. |
Signed-off-by: Morgan Tocker <[email protected]>
sougou
approved these changes
Mar 31, 2020
|
Tests are complaining about bad go version. |
Yep - see above, it should be fixed by a new Docker image. I'm pushing one now. |
Signed-off-by: Morgan Tocker <[email protected]>
|
The re-bootstrap is compete and the test that was failing is now passing. Just waiting for GitHub Actions to have free capacity to run tests (all my jobs appear to be queueing). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully not too controversial:
This removes the shard rebalancing make target, and the feature from test.go. It is not doing any harm, but we don't need this with GitHub actions - we can run unlimited shards.
I have also removed the
make installfeature which copies vtctl2 web files and config files. These are now embedded in rice boxes.Fixes a bug in echo'ing current go version when it is out of date.
Add k3s to dependency check for running tests.
Move failing sonar action to a special branch instead of master. When we get it working, we can enable on master again.
Signed-off-by: Morgan Tocker [email protected]