Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up TestExecutorDDL #5939

Merged
merged 2 commits into from
Mar 19, 2020
Merged

Conversation

teejae
Copy link
Contributor

@teejae teejae commented Mar 19, 2020

No description provided.

@teejae teejae requested a review from sougou as a code owner March 19, 2020 11:13
Copy link
Collaborator

@systay systay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Signed-off-by: Toliver Jue <[email protected]>
@teejae
Copy link
Contributor Author

teejae commented Mar 19, 2020

not sure what this PR has to do w/ local_example.

@morgo
Copy link
Contributor

morgo commented Mar 19, 2020

not sure what this PR has to do w/ local_example.

It looks like it might be a race - it is Local example using k8s on ubuntu-latest, which is a new test that only just merged:

..
W0319 11:26:08.760223   12593 main.go:64] W0319 11:26:08.759593 reparent.go:185] master-elect tablet zone1-0000000100 is not the shard master, proceeding anyway as -force was used
W0319 11:26:08.761121   12593 main.go:64] W0319 11:26:08.760402 reparent.go:191] master-elect tablet zone1-0000000100 is not a master in the shard, proceeding anyway as -force was used
New VSchema object:
{
  "tables": {
    "corder": {

    },
    "customer": {

    },
    "product": {

    }
  }
}
If this is not what you expected, check the input data (as JSON parsing will skip unexpected fields).
Waiting for vtgate to be up...
vtgate is up!
Access vtgate at http://fv-az89.4dgdkf1qd0xexjhfmua0pidohc.cx.internal.cloudapp.net:15001/debug/status
+ mysql -h 127.0.0.1 -P 15306
ERROR 1105 (HY000) at line 1: vtgate: http://fv-az89:15001/: execInsertUnsharded: target: commerce.0.master, used tablet: zone1-100 (fv-az89): vttablet: rpc error: code = FailedPrecondition desc = operation not allowed in state NOT_SERVING
##[error]Process completed with exit code 1.

I'm going to just restart it.

cc @carsonoid

@carsonoid
Copy link
Contributor

@morgo I'm sorry for the trouble. I'll look into the error. I had ran the test several times as part of the PR that initially created it and it never failed. But it's possible that it's just a really rare race condition.

@morgo morgo merged commit 9ce4e13 into vitessio:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants