Support SHOW statements for JIRA #5936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systay
reviewed
Mar 20, 2020
| @@ -830,6 +830,48 @@ func TestExecutorShow(t *testing.T) { | |||
| t.Errorf("Got: %v. Want: %v", lastQuery, wantQuery) | |||
| } | |||
|
|
|||
| // SHOW KEYS with two different syntax | |||
| _, err = executor.Execute(context.Background(), "TestExecute", session, fmt.Sprintf("show keys from %v.unknown", KsTestUnsharded), nil) | |||
| if err != nil { | |||
There was a problem hiding this comment.
nit: require.NoError(t, err) is nice to use
systay
approved these changes
Mar 20, 2020
Signed-off-by: Saif Alharthi <[email protected]>
Signed-off-by: Saif Alharthi <[email protected]>
systay
force-pushed
the
sa-jira-show-support
branch
from
24baf02
to
923531b
Compare
|
I took the liberty of doing the rebase. It was just a matter of doing a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies support for SHOW statements. It adds extra support for
SHOW INDEXandSHOW KEYSin particular.