Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass in cell to EnsureVSchema and GetOrCreateShard #5930

Merged
merged 7 commits into from
Apr 20, 2020
Merged

Pass in cell to EnsureVSchema and GetOrCreateShard #5930

merged 7 commits into from
Apr 20, 2020

Commits on Apr 16, 2020

  1. Refactor EnsureVSchema to take in a cell 

    Signed-off-by: Maggie Zhou <[email protected]>
    @zmagg
    zmagg committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    e8497f7 View commit details
    Browse the repository at this point in the history

  2. Add cell to GetOrCreateShard to the test files too. 

    Signed-off-by: Maggie Zhou <[email protected]>
    @zmagg
    zmagg committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    2a50906 View commit details
    Browse the repository at this point in the history

  3. Remove the nil check on CreateKeyspace to see if it lets you keep going 

    Signed-off-by: Maggie Zhou <[email protected]>
    @zmagg
    zmagg committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    1724a71 View commit details
    Browse the repository at this point in the history

  4. Respond to code review. Add back in the nil check for CreateKeyspace. 

    Remove empty line.

Signed-off-by: Maggie Zhou <[email protected]>
    @zmagg
    zmagg committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    5c29a6b View commit details
    Browse the repository at this point in the history

  5. conditionally createkeyspace if it doesn't exist already. 

    Signed-off-by: Maggie Zhou <[email protected]>
    @zmagg
    zmagg committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    ca85789 View commit details
    Browse the repository at this point in the history

  6. ok try with the flaky test 

    Signed-off-by: Maggie Zhou <[email protected]>
    @zmagg
    zmagg committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    72e75c1 View commit details
    Browse the repository at this point in the history

  7. If the keyspace already exists, don't try to create it again, it'll 

    throw an error

Signed-off-by: Maggie Zhou <[email protected]>
    @zmagg
    zmagg committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    f8edec4 View commit details
    Browse the repository at this point in the history