set default grpc values #5922
Merged
set default grpc values #5922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.set grpc_keepalive_timeout to 10 seconds These settings will help to avoid the situation which query will hang there when pod or Bare metal is broken. Signed-off-by: JohnnyThree <[email protected]>
|
This was previously reviewed here: #5478 -- we are good to merge. |
morgo
approved these changes
Mar 16, 2020
|
Unfortunately this introduces a somewhat odd behavior. Not sure if we should consider it a bug, but with these defaults for idle connections, we will be closing them in an incorrect way due to ping strikes. This is because, the defaults from this PR are not compatible with the defaults here. To make this clear with an example, the current settings of (grpc_keepalive_time=10s, grpc_keepalive_timeout=10s, grpc_server_keepalive_enforcement_policy_min_time=5min) will result in the following behavior:
I wonder what is the best approach here?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.set grpc_keepalive_time to 10 seconds
2.set grpc_keepalive_timeout to 10 seconds
These settings will help to avoid the situation which query will hang there when pod or Bare metal is broken.
Signed-off-by: JohnnyThree [email protected]