test case run into docker #5885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@morgo do we want to run all CI tests using docker? that is what this PR seems to be doing. |
I think I would rather not require Docker. It is okay if it is one specific test, but it makes it easier on contributors if this is optional (with only minimal dependencies) |
deepthi
reviewed
Mar 4, 2020
princeparmar
force-pushed
the
docker-for-e2e
branch
3 times, most recently
from
db971d8
to
bf581f3
Compare
failing because topo was not able to create err file. Signed-off-by: pradip parmar <[email protected]>
princeparmar
force-pushed
the
docker-for-e2e
branch
from
bf581f3
to
5b07a28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testcase was failing at Add Cell info.
while it was trying to create cell in etcd it was failing because of invalid error file.
error file was invalid because process was not able to create the error file and there was no check in the error of file creation.
process was not able to create file because the etcd data directory was not avaiable at that time.