config.json cleanup #5866
config.json cleanup #5866
Conversation
arindamnayak
force-pushed
the
config_cleanup
branch
3 times, most recently
from
1401fdc
to
1be35f6
Compare
deepthi
changed the title
| run: | | ||
| make minimaltools | ||
|
|
||
| - name: check_make_parser |
There was a problem hiding this comment.
is this supposed to be check_make_visitor?
| @@ -1,69 +1,25 @@ | |||
| { | |||
| "Tests": { | |||
| "check_make_parser": { | |||
There was a problem hiding this comment.
based on offline discussion, I think we should add the two check tests back.
There was a problem hiding this comment.
Since those are added to github actions, I removed it from here. But I have to keep the java test here, as it needs docker dependency and this is possible via go run test.go java . Whereas these 2 checks/tests does not need any docker dependency.
arindamnayak
force-pushed
the
config_cleanup
branch
from
d1d8af1
to
9d7950d
Compare
Signed-off-by: Ajeet jain <[email protected]> Signed-off-by: Arindam Nayak <[email protected]>
Signed-off-by: Arindam Nayak <[email protected]>
Signed-off-by: Arindam Nayak <[email protected]>
Signed-off-by: Arindam Nayak <[email protected]>
arindamnayak
force-pushed
the
config_cleanup
branch
2 times, most recently
from
200ba90
to
6b3a24d
Compare
Signed-off-by: Arindam Nayak <[email protected]>
arindamnayak
force-pushed
the
config_cleanup
branch
3 times, most recently
from
43edb19
to
af1058f
Compare
Signed-off-by: Arindam Nayak <[email protected]>
arindamnayak
force-pushed
the
config_cleanup
branch
from
af1058f
to
291540c
Compare
|
Do we need python vtgategrpc client test ? For now, I have added python GRPC library back to bootstrap.sh as python client testing (mainly vtgaterpc client test from python) needs the GRPC library. |
| export VTROOT=/<vitess path>/vitess | ||
| export VTDATAROOT=${VTROOT}/vtdataroot | ||
| export PATH=${VTROOT}/bin:${PATH} |
There was a problem hiding this comment.
Is this strictly required? build.env should be able to guess these. In future we may even be able to deprecate VTROOT as it can be implied.
There was a problem hiding this comment.
For now, it needs vitess binaries to be in PATH and we should also have VTDATAROOT . So when VTROOT deprecates, we can change this .
I think the answer is no. Let's remove it since it is really Python 2.7, which is no longer supported. |
arindamnayak
force-pushed
the
config_cleanup
branch
from
ef6375a
to
bcc756e
Compare
Signed-off-by: Arindam Nayak <[email protected]>
arindamnayak
force-pushed
the
config_cleanup
branch
from
bcc756e
to
2bff32b
Compare
Now, I have removed it and also changed the shard number of individually runnable test to -1. |
Migrated check_make_parser, check_make_visitor, java_test to github actions.
Removed python dependency from bootstrap.sh.
Signed-off-by: Ajeet jain [email protected]