-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrating messaging python testcase to go #5795
Conversation
princeparmar
commented
Feb 6, 2020
- connection with vtgate using grpc
- connection count validation using vttablet debug vars
- connection count validation after reparenting
- validation of message streaming
- moved ExecuteQueriesUsingVtgate method from recovery package to cluster_utils
- updated config.json
Signed-off-by: pradip parmar <[email protected]>
Signed-off-by: pradip parmar <[email protected]>
Signed-off-by: pradip parmar <[email protected]>
Signed-off-by: pradip parmar <[email protected]>
Signed-off-by: pradip parmar <[email protected]>
Signed-off-by: pradip parmar <[email protected]>
Signed-off-by: pradip parmar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good. Please resolve the conflicts and comments.
Signed-off-by: pradip parmar <[email protected]>
Signed-off-by: pradip parmar <[email protected]>
Signed-off-by: pradip parmar <[email protected]>
test/config.json
Outdated
"Args": [], | ||
"Command": [], | ||
"Manual": false, | ||
"Shard": 4, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the process so far has been to move python tests to shard 5 (which means they don't run at all) instead of removing them. but I'll approve this since we are very close to deleting them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM