Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrating messaging python testcase to go #5795

Merged
merged 10 commits into from
Feb 7, 2020

Conversation

princeparmar
Copy link
Contributor

  • connection with vtgate using grpc
  • connection count validation using vttablet debug vars
  • connection count validation after reparenting
  • validation of message streaming
  • moved ExecuteQueriesUsingVtgate method from recovery package to cluster_utils
  • updated config.json

@deepthi deepthi changed the title migratting messaging python testcase to go migrating messaging python testcase to go Feb 7, 2020
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. Please resolve the conflicts and comments.

go/test/endtoend/messaging/main_test.go Outdated Show resolved Hide resolved
go/test/endtoend/messaging/main_test.go Outdated Show resolved Hide resolved
test/config.json Outdated
"Args": [],
"Command": [],
"Manual": false,
"Shard": 4,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the process so far has been to move python tests to shard 5 (which means they don't run at all) instead of removing them. but I'll approve this since we are very close to deleting them.

Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepthi deepthi merged commit f4a573b into vitessio:master Feb 7, 2020
@ajeetj ajeetj deleted the messaging branch February 10, 2020 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants