Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add escape and quote to mysql password from mysqlctl/mysqld.go #5761

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Add escape and quote to mysql password from mysqlctl/mysqld.go #5761

merged 1 commit into from
Feb 24, 2020

Conversation

yindia
Copy link
Contributor

@yindia yindia commented Jan 24, 2020

Fixed #5060

@yindia yindia requested a review from morgo as a code owner January 24, 2020 17:53
@deepthi deepthi mentioned this pull request Jan 24, 2020
Open
@morgo morgo requested a review from enisoc January 24, 2020 20:31
@morgo
Copy link
Contributor

morgo commented Jan 24, 2020

I know we had troubles with #, but I am not sure if there is a list of other characters. Can we at least test out !@$%?

As an alternative-fix, if we enclose the option in quotes, does it work as expected without escaping?

@yindia
Copy link
Contributor Author

yindia commented Feb 24, 2020

@morgo I tested vitess with !@$% and it's working fine.

@morgo morgo merged commit 62f4a51 into vitessio:master Feb 24, 2020
@morgo
Copy link
Contributor

morgo commented Feb 24, 2020

Sounds good to me. Thanks!

@yindia yindia deleted the fix-5060 branch February 24, 2020 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgo morgo morgo approved these changes

@enisoc enisoc Awaiting requested review from enisoc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Temporary my.cnf file for ApplySchema does not quote values
2 participants
@yindia @morgo