-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite more functions #5732
Rewrite more functions #5732
Conversation
a27b6ec
to
bc40c03
Compare
There is a bug in
The first |
Well, I've only added parsing support so far. I have yet to add the bugs to the planner. ;) |
12050e5
to
d53b985
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the tabletserver part where we have to turn around, request found_rows()
and return it to vtgate.
That still needs to be implemented, right?
Everything else looks good.
acc0ac5
to
d12ffce
Compare
e3ecaa8
to
2bc44b1
Compare
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
if err == nil { | ||
safeSession.FoundRows = result.RowsAffected | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you not need locking around updating the foundRows?
go/vt/vtgate/engine/primitive.go
Outdated
|
||
sqlparser.BindVarNeeds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add comment for being in the plan like others. Also need to add json:"-" if this does not need json representation.
Signed-off-by: Harshit Gangal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm having problem with SQL_CALC_FOUND_ROWS not being Rewrite as well. Is this resolved? SELECT SQL_CALC_FOUND_ROWS t_posts.ID FROM t_posts WHERE 1=1 AND t_posts.post_type = 'post' AND (t_posts.post_status = 'publish') ORDER BY t_posts.post_date DESC LIMIT 0, 10 New Edit : i found out this was not updated in the vitess.io repo. |
This PR adds support for
SCHEMA()
andFOUND_ROWS()
.SQL_CALC_FOUND_ROWS
is being implemented in a separate PR