Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config.json file cleanup for ported tests return in GO #5694

Merged
merged 2 commits into from
Jan 13, 2020
Merged

config.json file cleanup for ported tests return in GO #5694

merged 2 commits into from
Jan 13, 2020

Conversation

ajeetj
Copy link
Contributor

@ajeetj ajeetj commented Jan 13, 2020 •
edited
Loading

  1. Updated config.json to add new ported tests in GO
  2. Updated config.json to remove the config for the files that are migrated.
  3. Cleanup for unrequired test
    -- cache_invalidation.py Not required https://planetscale.slack.com/archives/GNKDZJZ7T/p1576239710126300
    -- keyrange_test.py using v2 APIs, no need to convert
    -- vtgate_utils_test.py not needed, no need to convert
    -- vtgatev2 not needed, no need to convert

Signed-off-by: Ajeet jain [email protected]

@ajeetj
config.json file cleanup
5b8944f 
Signed-off-by: Ajeet jain <[email protected]>
@ajeetj ajeetj requested a review from sougou as a code owner January 13, 2020 05:06
@ajeetj
Copy link
Contributor Author

ajeetj commented Jan 13, 2020

@morgo @deepthi
Please review.

I have also removed a few tests which are in v2 and we have not ported those. Do let me know if that is fine.

@morgo morgo requested a review from deepthi January 13, 2020 06:43
@morgo
Copy link
Contributor

morgo commented Jan 13, 2020

LGTM

@ajeetj
balance travis shards
6b77117 
Signed-off-by: Ajeet jain <[email protected]>
@deepthi
Copy link
Member

deepthi commented Jan 13, 2020 •
edited
Loading

@morgo @deepthi
Please review.

I have also removed a few tests which are in v2 and we have not ported those. Do let me know if that is fine.

@morgo can you review the Makefile targets? (separate from this PR). make test used to run all tests and make unit_test only unit tests. Now make test runs unit tests. Also there's a target called site_test, not sure what it should do now.

deepthi
deepthi approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morgo morgo merged commit e677f35 into vitessio:master Jan 13, 2020
@morgo morgo mentioned this pull request Jan 13, 2020
Closed
@ajeetj ajeetj deleted the tal_test_cleanup branch January 14, 2020 03:10
@ajm188 ajm188 mentioned this pull request Mar 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajeetj @morgo @deepthi